(Un)premultiply colors in begin/end modify image + another fix - #10
Merged
Conversation
…gin/end modify image
Equbuxu
marked this pull request as ready for review
August 12, 2026 20:25
flabbet
approved these changes
Aug 18, 2026
flabbet
left a comment
Member
There was a problem hiding this comment.
looks good to me, requesting clanker for obvious mistakes
There was a problem hiding this comment.
Pull request overview
This PR updates the shader generation pipeline to work with straight-alpha colors during shader execution (by unpremultiplying sampled surface colors) and includes a parsing fix in the Skia shader implementation to correctly detect uniform types when the uniform name overlaps with layout/type tokens (e.g., layout(color) ... color).
Changes:
- Unpremultiply sampled
half4surface colors inShaderBuilder.Sample(...)before returning them to shader expressions. - Add a built-in
Unpremultiplyshader function (and aGetUnpremultiply(...)wrapper) to support the new sampling behavior. - Fix
SkiaShaderImplementation.TryDetectType(...)by removing only the last occurrence of the uniform name when analyzing the declaration string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Drawie.Backend.Skia/Implementations/SkiaShaderImplementation.cs | Fixes uniform type detection for edge cases where the uniform name appears in layout/type tokens. |
| src/Drawie.Backend.Core/Shaders/Generation/ShaderBuilder.cs | Unpremultiplies sampled surface colors before returning them to shader expressions. |
| src/Drawie.Backend.Core/Shaders/Generation/BuiltInFunctions.cs | Adds an Unpremultiply built-in shader function used by ShaderBuilder.Sample(...). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return null; | ||
| } | ||
|
|
||
| private static string RemoveLastOccurance(string text, string toRemove) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PixiEditor PR: PixiEditor/PixiEditor#1681