Tidy up the code, simplfy the internal mutable and call saveVals() instead of pointer (For discussion.)#1332
Open
balen wants to merge 1 commit into
Open
Tidy up the code, simplfy the internal mutable and call saveVals() instead of pointer (For discussion.)#1332balen wants to merge 1 commit into
balen wants to merge 1 commit into
Conversation
and call saveVals() instead of pointer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion.
We do not need the computed "mutable", and for a generic component such as the
pill display we do not want to mutate the store directly because it does not know what to mutate.
Does this make sense?
(it behaves the way we are expecting the UI to behave)