Skip to content

Fixes problems surfaced during Plotly 4 to 6 transition - #426

Merged
ryancdougherty merged 4 commits into
masterfrom
scatter
Aug 3, 2026
Merged

Fixes problems surfaced during Plotly 4 to 6 transition#426
ryancdougherty merged 4 commits into
masterfrom
scatter

Conversation

@ryancdougherty

Copy link
Copy Markdown
Contributor

Changes

  • Transition deprecated Scattermapbox plots to more general Scattermap plots

Fixes

  • Fixes file index bug which returned empty index slices in some cases
  • Extends file index tests

@ryancdougherty ryancdougherty self-assigned this Aug 3, 2026
Comment thread python/fusion_engine_client/parsers/file_index.py Outdated

@bhers4 bhers4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

fall back to Plotly's built-in token-free OpenStreetMap style.
"""
if not mapbox_token:
return 'open-street-map'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change from satellite-streets? Does satellite-streets only work with Mapbox?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Good catch.

@adamshapiro0 adamshapiro0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ryancdougherty
ryancdougherty merged commit 2d89b99 into master Aug 3, 2026
27 checks passed
@ryancdougherty
ryancdougherty deleted the scatter branch August 3, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants