CI: key the pages concurrency group by ref so PR pushes stop cancelling each other's site checks - #418
Merged
Merged
Conversation
…ter deploys The workflow-wide "pages" group made every pull_request run and every master push share one concurrency slot with cancel-in-progress: true, so a PR run could cancel master's site deploy (observed on the #235 merge, run 31521424173) and master pushes cancelled PR lint jobs before Ruff ran (observed on #386, job 93765266885). Keying the group by ref keeps cancellation within a single ref: a newer push to the same PR or to master cancels only its own older run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy.ymldeclaresconcurrency: group: "pages"withcancel-in-progress: trueand no per-ref key, so any push in the repo cancels whatever site run is in flight: a second PR's push cancels the first PR'sbuild/lint/deploychecks (rendered asfailwith empty logs), and a PR push cancels an in-progress master deploy. Seen today: PR #417's push cancelled PR #416's run 33872523405, and #417's merge cancelled the master deploy for e28f479.Keys the group by
github.ref(pages-${{ github.ref }}): each PR branch and master get their own group, so runs on the same ref still supersede each other while unrelated refs no longer interfere. One-line change; no other behavior touched. (Cherry-picks the long-standing unmerged branchfix/pages-concurrency-per-refonto current master.)🤖 Generated with Claude Code