Fix managed population simulations - #265
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Beta preview has been cleaned up because this PR was closed. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 73.41% 75.08% +1.67%
==========================================
Files 152 154 +2
Lines 11403 11834 +431
Branches 1963 2020 +57
==========================================
+ Hits 8371 8886 +515
+ Misses 2309 2193 -116
- Partials 723 755 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266
Fixes #264
Summary
Enhanced FRS 2024-25and persists typed dataset provenance without exposing the private URI;household_net_incomeconsistently for both decile impacts and winner/loser groups by default, while retaining explicit equivalised-HBAI and wealth-decile options across initial calculations and follow-up reruns;societal_impactas requests for the default population output profile;Production failures addressed
UK Chat previously passed an explicit Hugging Face dataset URI to policyengine.py's managed-data API. That API rejects explicit URIs unless unmanaged loading is deliberately enabled, so the population calculation stopped before dataset materialization. UK Chat now omits the dataset selector and lets policyengine.py select, verify, and materialize its certified default dataset. Unmanaged loading remains disabled.
The prior winner/loser calculation measured changes in ordinary household net income while grouping households with an HBAI-equivalised income-decile variable. The default calculation now measures and forms groups from ordinary household net income for both distributional outputs. Poverty and inequality keep their established equivalised HBAI definitions and responses state those definitions explicitly.
Verification