Skip to content

[codex] Add scenario perf adapter#817

Merged
bill-ph merged 1 commit into
mainfrom
codex/scenario-runner-pr5-perf-adapter
Jun 26, 2026
Merged

[codex] Add scenario perf adapter#817
bill-ph merged 1 commit into
mainfrom
codex/scenario-runner-pr5-perf-adapter

Conversation

@bill-ph

@bill-ph bill-ph commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds the PR5 scenario perf adapter so perf is a workload step inside the Duckgres Scenario Runner instead of only a standalone harness.

  • add tests/scenario/perf with a perf_queries executor that reuses tests/perf/core.QueryRunner, existing perf drivers, and ArtifactSink
  • add posthog_frozen_perf.yaml to provision a fresh dev warehouse, create frozen file views, run the existing frozen perf catalog, and deprovision
  • write perf artifacts under artifacts/scenario/<run_id>/perf/ while preserving the existing query_results.csv schema
  • fail the scenario step when the perf summary records measured query errors so scenario cleanup still runs
  • support Flight SNI by dialing DUCKGRES_SCENARIO_FLIGHT_ADDR with the run-specific managed hostname as TLS ServerName
  • make scripts/scenario_run.sh --check-env include scenario-specific required_env

Validation

  • GOCACHE=/tmp/duckgres-pr5-review-gocache go test ./tests/scenario/... ./tests/perf/...
  • just test-scenario
  • just lint
  • git diff --check

I did not run the live dev frozen perf scenario in this checkout because the real dev scenario API/PG/Flight/S3 environment is not configured here.

@github-actions

Copy link
Copy Markdown

Test Impact Plan

Deterministic summary of how this PR changes tests, CI runners, and coverage-risk signals.

Summary

Area Added Changed Deleted
Test files 4 4 0
E2E/journey files 0 0 0
Workflow files 0 0 0

Signals

  • Test cases: +7 / -0
  • Assertions: +45 / -0
  • Skips or known failures added: 0
  • Workflow continue-on-error added: 0
  • Workflow path filters added: 0
  • Test commands removed from justfile: 0
  • E2E/journey retry lines added: 0

Coverage risk: neutral or increased

No coverage-reduction warnings detected.

@bill-ph bill-ph marked this pull request as ready for review June 26, 2026 17:32
@bill-ph bill-ph merged commit a751d58 into main Jun 26, 2026
28 checks passed
@bill-ph bill-ph deleted the codex/scenario-runner-pr5-perf-adapter branch June 26, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant