[codex] Add scenario perf adapter#817
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the PR5 scenario perf adapter so perf is a workload step inside the Duckgres Scenario Runner instead of only a standalone harness.
tests/scenario/perfwith aperf_queriesexecutor that reusestests/perf/core.QueryRunner, existing perf drivers, andArtifactSinkposthog_frozen_perf.yamlto provision a fresh dev warehouse, create frozen file views, run the existing frozen perf catalog, and deprovisionartifacts/scenario/<run_id>/perf/while preserving the existingquery_results.csvschemaDUCKGRES_SCENARIO_FLIGHT_ADDRwith the run-specific managed hostname as TLSServerNamescripts/scenario_run.sh --check-envinclude scenario-specificrequired_envValidation
GOCACHE=/tmp/duckgres-pr5-review-gocache go test ./tests/scenario/... ./tests/perf/...just test-scenariojust lintgit diff --checkI did not run the live dev frozen perf scenario in this checkout because the real dev scenario API/PG/Flight/S3 environment is not configured here.