configstore: drop dead/footgun per-org Org columns (memory_budget, idle_timeout_s, worker_*_request)#825
Merged
Merged
Conversation
Removes four duckgres_orgs columns: - memory_budget, idle_timeout_s — dead: only copied to the snapshot OrgConfig + shown in admin OrgStatus; no behavioral reader. - worker_cpu_request, worker_memory_request — footgun: org_router applied the per-org value to the SHARED worker pool (last-org-wins pod sizing across all orgs). Per-org sizing stays via default_worker_cpu/memory + client GUCs; the deployment-wide K8sConfig.WorkerCPURequest/MemoryRequest (charts/env) is a separate, kept field. Drops the two SetWorkerResources footgun blocks from org_router; new migration 000005 drops the columns (Down re-adds); updates OrgConfig snapshot view, admin OrgStatus, seeds, and tests. Split out of #822 (which squash-merged before this landed): same configstore cleanup, new migration version since 000004 is already merged/applied.
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: needs review Warnings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #822 (which squash-merged before these landed — hence a separate PR + a new migration
000005, since000004is already merged/applied).Removes four
duckgres_orgscolumns:memory_budget,idle_timeout_s— dead: only copied into the snapshotOrgConfig+ shown in adminOrgStatus; nothing reads them to drive behavior.worker_cpu_request,worker_memory_request— footgun:org_routerapplied the per-org value to the shared worker pool (SetWorkerResources), so one org's setting changed pod sizing for every org (last-org-wins). Legit per-org sizing stays viadefault_worker_cpu/memory+ client GUCs; the deployment-wideK8sConfig.WorkerCPURequest/MemoryRequest(charts/env, read inworker_profile.go) is a different field and is untouched.Removes the two
SetWorkerResourcesfootgun blocks fromorg_router(createOrgStack + HandleConfigChange); the pool method stays (still unit-tested). New migration000005drops the columns (Down re-adds); updates theOrgConfigsnapshot view, adminOrgStatus, seed SQL, and tests (incl. the goose version-parity assertion → 5).Verified:
go build ./...,go build -tags kubernetes ./controlplane/... ./cmd/..., all test binaries compile (both tag sets), configstore unit tests pass. Postgres/e2e in CI.🤖 Generated with Claude Code