docs: agree on public API changes before implementing them - #577
Open
turnipdabeets wants to merge 2 commits into
Open
docs: agree on public API changes before implementing them#577turnipdabeets wants to merge 2 commits into
turnipdabeets wants to merge 2 commits into
Conversation
Contributor
posthog-flutter Compliance ReportDate: 2026-09-11 14:21:52 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
turnipdabeets
marked this pull request as ready for review
September 11, 2026 14:16
|
Reviews (1): Last reviewed commit: "docs: agree on public API changes before..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Port of PostHog/posthog-js#4906 to posthog-flutter.
On contributor PRs we sometimes only settle the public API after several rounds of implementation review. By then the contributor, or their agent, has built each suggestion along the way, and a late change of direction wastes their work. This asks contributors to agree on the API shape on the issue first, and tells their agents to stop and ask.
CONTRIBUTING.md: new "Public API changes" section, same as posthog-js. The last paragraph points atmake updateApiDart/make checkApiDartand theapi/posthog_flutter.api.jsonsnapshot.AGENTS.md: new file, since this repo didn't have one. Modeled on the posthog-js one: it points agents toCONTRIBUTING.md,RELEASING.md, and the new section, and asks to keep shared guidance out ofAGENTS.md.💚 How did you test it?
Docs only. Checked that the commands and file paths it mentions exist in this repo.
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
beforeSendexample to this SDK.🤖 Generated with Claude Code
https://claude.ai/code/session_016syAmdpp8imNvs7PWkpwvb