chore(test): trim redundant large-org case from web digest concurrency tests#66372
Draft
gantoine wants to merge 1 commit into
Draft
chore(test): trim redundant large-org case from web digest concurrency tests#66372gantoine wants to merge 1 commit into
gantoine wants to merge 1 commit into
Conversation
…y tests Both concurrency-cap tests were parameterized over a small and a large org count. The small case (50 orgs, batch 5, cap 4) already schedules 10 batches against a cap of 4, so it fully exercises the semaphore fan-out guard the test asserts. The large case (500/200 orgs, cap 8) tests the identical code path — the cap is independent of org count once batches exceed it — but spins a Worker with hundreds of concurrent activities for no extra signal. Keep the small case. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Reviews (1): Last reviewed commit: "chore(test): trim redundant large-org ca..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The two web-analytics digest concurrency tests (
test_wa_weekly_digest_respects_concurrency_capandtest_respects_concurrency_cap) were each parameterized over a small and a large org count. The large case (500/200orgs, cap 8) spins a TemporalWorkerwith hundreds of concurrent activities but exercises the exact same code path as the small case.Changes
(org_count=50, batch_size=5, max_concurrent=4).The semaphore fan-out guard the test asserts (
tracker.max_in_flight <= max_concurrent) is independent of org count once the number of batches exceeds the cap. The small case already schedules 10 batches against a cap of 4, so it drivesmax_in_flightpast the cap and fully catches a missing/broken semaphore. The large case adds wall-time, not signal.How did you test this code?
I'm an agent. Ran locally:
Result: 13 passed.
🤖 Agent context
Autonomy: Fully autonomous
Part of a monorepo test-suite cleanup targeting high CI-wall-time tests. Adversarial check before trimming: the dropped case can only differ from the kept case if the cap logic depends on absolute org count, which it does not — both cross the cap threshold, so the regression caught is identical. Tool: Claude Code (Opus 4.8).
Requesting review from: Web analytics