chore(data-modeling): relocate api views into presentation/views#66376
Open
Gilbert09 wants to merge 3 commits into
Open
chore(data-modeling): relocate api views into presentation/views#66376Gilbert09 wants to merge 3 commits into
Gilbert09 wants to merge 3 commits into
Conversation
First step of data_modeling isolation: moves backend/api/{dag,edge,node}.py into backend/presentation/views/ (and api/test into tests/api), rewriting dotted paths repo-wide via hogli product:isolate:move. Views keep import-linter allowances to reach internals for now; they route through the facade in the presentation-wave follow-up.
Contributor
|
Full data_modeling isolation in one PR (on top of the api->presentation move): adds the facade (models eager re-exports, api lazy services, tasks, contracts), sweeps all external consumers onto it (166+ imports, residual none), routes the 3 views through the facade, and enforces via the canonical [[interfaces]] block. Structural: tsconfig.json + manifest.tsx, and backend/services -> backend/logic (canonical dir). A narrow legacy-leak exposes models to frozen Django migrations only. Removing the now-obsolete allowances also clears 12 of data_warehouse's 24 cross-product allowances (the data_modeling-targeted ones). backend:contract-check stays off (the migration leak is permanent).
Contributor
|
Size Change: 0 B Total Size: 64.3 MB ℹ️ View Unchanged
|
models.node.NodeType (table/view/matview/endpoint) and models.modeling.NodeType (SAVED_QUERY/POSTHOG) are distinct classes; the consumer sweep conflated them under facade.models, breaking modeling.NodeType consumers (mypy attr-defined). Add facade.modeling for the resolver surface (DataWarehouseModelPath, BoundedResolver, resolution errors, and modeling's NodeType), keep node's NodeType in facade.models, and re-route the modeling-resolver consumers per-symbol (NodeType disambiguated by original source — only test_modeling needs modeling's).
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening the data_modeling isolation (it's the biggest cross-product blocker for data_warehouse's
backend:contract-check). This first step is the structural prerequisite — relocating its API views into the canonicalpresentation/views/layout — so the facade + sweep can follow on a compliant structure.Changes
backend/api/{dag,edge,node}.py→backend/presentation/views/andbackend/api/test/→backend/tests/api/, rewriting dotted paths repo-wide (hogli product:isolate:move).presentation.views.{dag,edge,node} -> backend.{models,graph}) — deferring them to the presentation-wave follow-up, exactly as data_warehouse did.No behavior change; this is a mechanical relocation + path rewrite.
How did you test this code?
tach check --dependencies --interfaces→ All modules validated.lint-imports→ presentation contract KEPT, 0 broken.ruff+py_compileclean.Behavioral tests run in CI (identity-preserving move).
Docs update
No user-facing docs changes.