Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A malformed tool in a user's inherited MCP configuration can prevent the Wizard's Anthropic agent from starting, even though its own MCP servers are valid. Addresses #1091.
Changes
Set
strictMcpConfig: trueat both SDK query call sites. Regression tests cover the main agent and tutorial, including resumed queries and the main agent's explicit subagent server names.The error deduplication and message improvements described in the issue remain separate.
Test plan
The new assertions failed before the fix. All 249 tests across the agent test directory and agent-interface suite pass afterward. Build, CLI smoke checks, Warlock smoke checks, and formatting/lint on the changed files pass.
Using the pinned SDK 0.3.169 against a local provider fixture, the current configuration sent 27 tools including the malformed inherited tool. With isolation enabled it sent 26, keeping the explicit server. A dispatched general-purpose subagent also retained that server and excluded the inherited one. The fixture models the reported 400; this was not a live Anthropic call.
pnpm typecheckreports the same 27 existing errors on this branch and untouchedmainate88050da. None are in changed files. A full authenticated Wizard install was not run.LLM context
Agent-assisted contribution. Codex helped reproduce the issue, implement and test the fix, and perform independent code and security reviews.