fix: noramlize path for working directory - #1259
Open
edwinyjlim wants to merge 1 commit into
Open
edwinyjlim wants to merge 1 commit into
edwinyjlim wants to merge 1 commit into
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://us.posthog.com/project/2/support/tickets/72326?assignee=%5B%22role%3A019d8b94-166a-0000-538b-140af1883beb%22%5D
robot comment:
The reported "path traversal" failure was a normalization bug. The guards compared a
path.resolve()-normalized path against the raw working-directory string, so a trailing-slash or relative install dir (e.g.--install-dir=my-app/) rejected every env write — including plain .env — with no fallback, sinceset_env_valuesis the only sanctioned env channel. Init then failed and the orchestrator correctly aborted.The fix canonicalizes the root before comparing (
inresolveEnvPathand the rm gate) and normalizesinstallDironce at both runner entry points.