refactor: migrate cross-boundary relative imports to path aliases#485
Open
gewenyu99 wants to merge 1 commit into
Open
refactor: migrate cross-boundary relative imports to path aliases#485gewenyu99 wants to merge 1 commit into
gewenyu99 wants to merge 1 commit into
Conversation
The tsconfig already declared `@env`, `@lib/*`, `@utils/*`, `@ui/*`,
`@steps/*`, and `@frameworks/*` aliases, but only `@env` was actually
being used — everything else still leaned on `../../../...` chains.
This sweep:
- Adds non-wildcard `@ui` and `@steps` aliases so directory-style
imports (`import { getUI } from '@ui'`) resolve via the index file,
matching how the wildcard aliases handle nested paths.
- Mirrors the same change in Jest's `moduleNameMapper`.
- Rewrites every relative import that crossed a top-level src/
boundary to use the appropriate alias. Same-directory imports
(`./foo`) are left alone.
- Drops the `.js` suffix from aliased imports — Jest's mapper can't
resolve `@lib/foo.js` to a `.ts` file, and the bundler resolves
alias paths without needing the extension.
No behavior changes. `pnpm build`, `pnpm jest` (645/645), and
`pnpm lint` all clean.
Generated-By: PostHog Code
Task-Id: a03625d7-3f4a-408e-8c35-a57678c42f36
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@env,@lib/*,@utils/*,@ui/*,@steps/*, and@frameworks/*aliases, but only@envwas actually being used — everything else still leaned on../../../...chains. This sweep makes the codebase actually use them.@uiand@stepsaliases (mirrored in Jest'smoduleNameMapper) so directory-style imports likeimport { getUI } from '@ui'resolve through the package'sindex.ts. The existing wildcard aliases only handle nested paths../foo) are intentionally left alone..jssuffix from aliased imports — Jest's mapper can't resolve@lib/foo.jsto a.tsfile, and the bundler resolves aliased paths without needing the extension.253 files touched, no behavior changes.
Test plan
pnpm buildpasses (smoke test included)pnpm jest— 645/645 tests passpnpm lint— 0 errors (pre-existing warnings only)pnpm typecheckclean