fix(coding-agent): kernel test fixtures speak protocol 3 - #1886
Open
snimu wants to merge 1 commit into
Open
Conversation
The fake-runtime fixtures in the REPL corruption and provisioner suites still announced protocol 2 after the runtime moved to REPL_PROTOCOL_VERSION = 3, so 23 tests failed deterministically on a clean checkout with the protocol-mismatch error instead of exercising their scenarios. The constant is module-private in repl-manager.ts, so the fixtures use the literal 3.
rynfar
pushed a commit
to pylon-code/prime-agent
that referenced
this pull request
Aug 29, 2026
Merge the exact repair from PrimeIntellect-ai#1886 after the upstream main merge regressed protocol fixtures.
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repl-kernel-protocol-corruption.test.ts(lines 35/38) andipython-provisioner.test.ts(line 76) hardcodeprotocol: 2, whilerepl-manager.tsrequiresREPL_PROTOCOL_VERSION = 3REPL_PROTOCOL_VERSIONis module-private, so the fixtures use the literal rather than importing itValidation
npm run check: biome, tsgo, installer render, and browser smoke all passsrc/changes only)Note
Low Risk
Only updates embedded test fixture strings; no runtime or security impact.
Overview
Test-only fix: fake Node-based REPL runtimes in
ipython-provisioner.test.tsandrepl-kernel-protocol-corruption.test.tsnow advertiseprotocol: 3on theirreadyevents instead ofprotocol: 2.That matches what
ReplKernelManagerenforces (REPL_PROTOCOL_VERSION = 3), so kernel tests stop failing immediately with “Kernel runtime speaks protocol 2, expected 3” before exercising provisioner or protocol-corruption behavior. No production code changes.Reviewed by Cursor Bugbot for commit a97f699. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Bump kernel test fixtures to protocol 3
Updates the
protocolfield from 2 to 3 in the ready event emitted by embedded child-process scripts across two test fixtures. Affects both the normal boot path and theREADY_WITH_GARBAGEpath in the fake REPL script.Macroscope summarized a97f699.