Skip to content

bump oversampling defaults#512

Open
Jackmin801 wants to merge 2 commits intomainfrom
bump-oversampling-defaults
Open

bump oversampling defaults#512
Jackmin801 wants to merge 2 commits intomainfrom
bump-oversampling-defaults

Conversation

@Jackmin801
Copy link
Copy Markdown
Member

@Jackmin801 Jackmin801 commented Apr 13, 2026

Higher oversampling default should make the averange run more efficient as it schedules more concurrent requests


Note

Medium Risk
Changes default RL run behavior by enabling oversampling (oversampling_factor=1.5) when not explicitly configured, which can increase compute usage and alter training dynamics. Also updates the generated config template’s recommended max_async_level, affecting throughput expectations.

Overview
Makes oversampling_factor default to 1.5 in RLConfig, so runs oversample unless users explicitly disable/override it.

Updates the prime rl init TOML template comments to reflect the new oversampling default and a lower recommended max_async_level (2 vs 4).

Reviewed by Cursor Bugbot for commit a48e7ee. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a48e7ee. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant