Adapt to https://github.com/rocq-prover/rocq/pull/21947#855
Merged
Conversation
5 tasks
Contributor
Author
|
CI green in the upstream PR, please merge |
SkySkimmer
reviewed
May 18, 2026
| Global Set Asymmetric Patterns. (* This was in CompCert up to 3.9, | ||
| and has been removed, which was a good idea but now we must have it | ||
| here in VST until we remove it . . . *) | ||
| #[warning="-unknown-option"] Global Set Asymmetric Patterns No Implicits. |
Contributor
There was a problem hiding this comment.
we really shouldn't use global
Collaborator
There was a problem hiding this comment.
There are lots of Globals, some dating back to 2008 when I had no choice. Perhaps I should make a pass through and remove as many as possible. However, this particular P.R. makes things no worse, really.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#21947
Should be backward compatible