ci: android jobs install only platform-tools (legacy 'tools' SDK package removed) - #175
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent review context: release run 34933324419 failed in
android-arm64duringSetup Android SDKwithFailed to find package 'tools'/ sdkmanager exit 1.android-actions/setup-androiddefaults to installing the legacytoolspackage, which is no longer in the Android SDK repository. Upstream hit the same failure today and fixed it in 987498f (ggml-org#28936) by pinningpackages: 'platform-tools'.This applies the same one-line change to the setup-android steps in
release-prism.ymlandbuild-android.yml. The followingInstall NDKstep already installs the NDK explicitly, so nothing else changes.