-
Notifications
You must be signed in to change notification settings - Fork 6
97 node migration #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
97 node migration #100
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8cc568a
docs(node): add migration guide and changes for v0.1.0
brucetony 7af6df3
docs(node): update guides to use new values
brucetony 312d5b5
refactor: change to v0.0.12
brucetony da49cb4
docs(node): update v0.1.0 changes
brucetony f8e9db2
Merge branch '97-node-migration' of github.com:PrivateAIM/documentati…
brucetony 6964b41
revert(node): revert file name
brucetony b0619df
docs(node): update node installation
brucetony 5fe3422
chore: typos and remove duplicates
brucetony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,14 @@ | ||
| export const versionRoutes = [ | ||
| { | ||
| text: '0.1.0', | ||
| link: '/v0.1.0' | ||
| }, | ||
| { | ||
| text: '0.0.11', | ||
| link: '/v0.0.11' | ||
| }, | ||
| { | ||
| text: '0.0.10', | ||
| link: '/v0.0.10' | ||
| }, | ||
| ] | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # v0.0.11 | ||
|
|
||
| ## Node | ||
| ### Helm | ||
| Several performance modifications were made to improve deployment and a fix was applied to allow UI sign in when | ||
| ingress is disabled | ||
|
|
||
|
|
||
| ### UI | ||
| #### Private S3 Bucket Data Stores | ||
| Private buckets are now supported when creating a data store using an S3 bucket. Full documentation on how to do this | ||
| can be found [here](https://docs.privateaim.net/guide/admin/bucket-setup-for-data-store.html). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| # v0.1.0 | ||
|
|
||
| > This release contains breaking changes for the `flame/flame-node` helm chart | ||
|
|
||
| ## Node | ||
|
|
||
| In an effort to ensure long-term support, we have added the ability to use the kubernetes Gateway API in addition to the | ||
| Ingress API since the latter has been deprecated. This resulted in having to make a breaking change to the `values.yaml` | ||
| file to support both APIs. This means that values files from prior versions are not compatible with this new helm chart. | ||
| Users will have to update their `values.yaml` file in order to upgrade to `v0.1.0`. | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| #### Removed global Values | ||
|
|
||
| The `global` section at the top of the `flame-node` helm chart `values.yaml` | ||
| file. This was previously used to simplify distributing the provided hostname to the chart and its | ||
| sub-charts, but is no longer necessary so it was removed. Likewise, the ingress sections for both this helm chart and | ||
| the sub-charts were removed. | ||
|
|
||
| ```diff | ||
| -global: | ||
| - node: | ||
| - ingress: | ||
| - enabled: false | ||
| - hostname: | ||
| +expose: | ||
| + type: none | ||
| + hostname: "" | ||
| + tls: | ||
| + secretName: "" | ||
| + ingress: | ||
| + className: "" | ||
| + annotations: {} | ||
| + pathType: ImplementationSpecific | ||
| + gateway: | ||
| + gatewayClassName: nginx | ||
| ``` | ||
|
|
||
| In order to allow network routing, users must use the new `expose` section and for the `type`, choose one of the | ||
| following: | ||
|
|
||
| * "ingress" (Kubernetes Ingress API) | ||
| * "gateway" (Kubernetes Gateway API) | ||
| * "none" (no external routing) | ||
|
|
||
| Regardless if one chooses "ingress" or "gateway", the hostname and tls fields will be applied to the selected API. | ||
|
|
||
| #### Robot to Client | ||
|
|
||
| Hub keys were updated and the `values.yaml` was updated accordingly: | ||
|
|
||
| ```diff | ||
| hub: | ||
| auth: | ||
| - robotUser: <Robot ID> | ||
| - robotSecret: <Robot Secret> | ||
| + clientID: <Client ID> | ||
| + clientSecret: <Client Secret> | ||
| ``` | ||
|
|
||
| #### Improving Security | ||
|
|
||
| ##### Default credentials | ||
| Several default credentials were removed including keycloak and minio. Users must now specify these credentials when deploying by either providing a username/password directly in the `values.yaml` file or by using an existing secret. The keycloak user `flameuser` is no longer included by default unless explicitly enabled. | ||
|
|
||
| ```diff | ||
| keycloakx: | ||
| + defaultUserEnabled: false | ||
| + auth: | ||
| + adminUsername: "" | ||
| + adminPassword: "" | ||
| + existingSecret: "" | ||
|
|
||
| +dataStore: | ||
| enabled: true | ||
| minio: | ||
| + rootUser: "" | ||
| + rootPassword: "" | ||
| + existingSecret: "" | ||
| ``` | ||
|
|
||
| ##### Node VictoriaLogs UI | ||
| VictoriaLogs is now the primary application for storing and serving logs from all node related components and services. It is enabled by default, but access to it's included UI is disabled as it is not currently secured behind user authentication. If ingress for the VictoriaLogs UI is enabled, it can be found at `https://<node hostname>/logs/select/vmui` | ||
|
|
||
| ```diff | ||
| +victorialogs: | ||
| + enabled: true | ||
| + ingress: | ||
| + enabled: false | ||
| ``` | ||
|
|
||
| #### flame-node-data-store to dataStore | ||
| To simplify referencing this subchart in the helper functions, it was given an alias of `dataStore` which should now be used instead | ||
|
|
||
| ```diff | ||
| - flame-node-data-store: | ||
| + dataStore: | ||
| enabled: true | ||
| ``` | ||
|
|
||
| ### Migration Guide | ||
|
|
||
| Adapting previous versions to the current one is very straightforward, the following table shows how values map from | ||
| `values.yaml` files from previous versions (i.e. `<0.1.0`) to the current stable version (`0.1.0`): | ||
|
|
||
| | Previous Value | Current Value | Comment | | ||
| |----------------------------------------------------------------------------------------------------------|---------------------------------------------|----------------------------------------------------------------------------------------| | ||
| | `.global.node.ingress.enabled` == "true"<br>`.ingress.enabled` == "true" | `.expose.type` == "ingress" | This can also be set to "gateway" if you are using the new Gateway API | | ||
| | `.global.node.ingress.enabled` == "false"<br>`.ingress.enabled` == "false" | `.expose.type` == "none" | | | ||
| | `.global.node.ingress.hostname` == "https://your-domain"<br>`.ingress.hostname` == "https://your-domain" | `.expose.hostname` == "https://your-domain" | | | ||
| | `.ingress.annotations` | `.expose.ingress.annotations` | | | ||
| | `.ingress.className` | `.expose.ingress.className` | | | ||
| | `.ingress.pathType` | `.expose.ingress.pathType` | | | ||
| | `.ingress.tlsSecretName` | `.expose.tls.secretName` | | | ||
| | `.hub.auth.robotUser` | `.hub.auth.clientID` | | | ||
| | `.hub.auth.robotSecret` | `.hub.auth.clientSecret` | | | ||
| | `.flame-node-data-store` | `.dataStore` | | | ||
| | | `.keycloakx.defaultUserEnabled` | Enable if you want the `flameuser` test user created in your bundled keycloak instance | | ||
| | | `.keycloakx.auth` | Enter your admin credentials in these fields | | ||
| | | `.dataStore.minio` | If the dataStore is `enabled`, enter your admin credentials here | | ||
| | | `.victorialogs.ingress.enabled` | Set to `true` if you want to access the VictoriaLogs UI | | ||
| | | `.proxy.existingSecret` | Can now set proxy information using an existing secret | |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.