fix: hide redundant movie title text in pause overlay when clearlogo is present#414
Open
EierKopZA wants to merge 2 commits into
Open
fix: hide redundant movie title text in pause overlay when clearlogo is present#414EierKopZA wants to merge 2 commits into
EierKopZA wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pause-overlay metadata UI (PlayerMetadataChrome) to avoid rendering redundant title text under a clearlogo by restricting when the secondary title line is shown.
Changes:
- Tighten the condition for rendering the secondary
displayTitletext when alogoUrlis present by adding amediaType == MediaType.TVguard.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug:
In PlayerMetadataChrome, the composable showed the title text below the clearlogo whenever both existed — regardless of media type. For movies, displayTitle is the movie name (e.g. "The Dark Knight"), which is redundant with the clearlogo branding.
The fix:
Added mediaType == MediaType.TV to the condition at line 5294, so the secondary title text only appears for TV shows where displayTitle is the episode title (e.g. "Winter Is Coming") — genuinely different from the show clearlogo.