feat: add loading screen customization (animation style, progress style background treatment#418
Open
EierKopZA wants to merge 1 commit into
Open
Conversation
…le, background treatment)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new per-profile Appearance settings to customize the player loading/buffering clearlogo presentation (animation style, progress indicator style, and background treatment), and threads these settings through settings UI → DataStore → player UI.
Changes:
- Added three new cycle settings (loading animation, loading progress, loading background) persisted via DataStore and surfaced in the Appearance section.
- Extended
PlayerUiStateandSettingsUiStateto carry the new preferences and applied them in the loading/buffering UI. - Updated the loading screen UI to support multiple animation/progress styles and accent-colored indicators.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds new strings for the three new loading customization rows (labels + descriptions). |
| app/src/main/kotlin/com/arflix/tv/ui/screens/settings/SettingsViewModel.kt | Adds new DataStore keys/state fields and cycle functions for loading customization preferences. |
| app/src/main/kotlin/com/arflix/tv/ui/screens/settings/SettingsScreen.kt | Adds three new Appearance rows and wires click handlers to cycle the new preferences. |
| app/src/main/kotlin/com/arflix/tv/ui/screens/player/PlayerViewModel.kt | Reads new DataStore values into PlayerUiState for use by the player UI. |
| app/src/main/kotlin/com/arflix/tv/ui/screens/player/PlayerScreen.kt | Updates loading/buffering overlays and rewrites PulsingLogo to support new animation/progress styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2643
to
+2647
| Box( | ||
| modifier = Modifier.fillMaxSize(), | ||
| contentAlignment = Alignment.Center | ||
| ) { | ||
| if (uiState.backdropUrl != null) { | ||
| if (uiState.backdropUrl != null && uiState.loadingBackground == "Backdrop") { |
Comment on lines
2676
to
+2680
| Box( | ||
| modifier = Modifier.fillMaxSize(), | ||
| contentAlignment = Alignment.Center | ||
| ) { | ||
| PulsingLogo(logoUrl = uiState.logoUrl, title = uiState.title) | ||
| PulsingLogo( |
Comment on lines
+3699
to
+3703
| "Glow" -> { | ||
| // Scale remains steady; alpha pulses instead | ||
| durationMillis = 1 | ||
| 1.0f at 0 | ||
| 1.0f at 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Loading Screen Customization
Adds three new cycle settings to the Appearance section that give users full control over how the clearlogo loading screen looks during playback startup and mid-stream buffering.
Settings Added (Appearance section)
Animation Styles
Progress Styles
Background Treatment
Technical Details
LocalAccentColorOverride.current.PulsingLogocomposable was rewritten to accept three new parameters (animationStyle,progressStyle,backgroundStyle) that flow fromPlayerUiState→PlayerScreen.cycleAccentColor().loadingBackground("Backdrop" shows art + overlay, "Dark" shows plain black).Files Modified
SettingsViewModel.kt— Added 3 DataStore string keys, 3 state fields (loadingAnimationStyle,loadingProgressStyle,loadingBackground), 3 cycle functionsSettingsScreen.kt— Added 3 new settings rows to the Appearance section with proper focus wiringstrings.xml— Added 6 string resources for labels and descriptionsPlayerViewModel.kt— Added 3 fields toPlayerUiState+ DataStore reads in init blockPlayerScreen.kt— RewrotePulsingLogocomposable (lines 3654→3761) with all animation/progress/background styles; updated loading screen container for backdrop toggle