cecc-client --help / --list-devices - #747
Open
barak wants to merge 2 commits into
Open
Conversation
cecc-client -h/--help, sets the log level and returns 0 without
printing anything; it's a commented-out call to a nonexistent
procedure:
// TODO ShowHelpCommandLine(argv[0]);
This patch implements it.
Gbp-Pq: Name 0004-implement-cecc-client-help.patch
cecc-client -l/--list-devices initialises libCEC, calls cec_list_devices(), and destroys it again, but cec_list_devices() is an empty //TODO, so the option prints nothing. Fill it in with detect_adapters(), replicating what cec-client's ListDevices() prints. strftime() replaces the asctime() the C++ client uses for the firmware build date. This means no trailing newline to strip and no static buffer. Gbp-Pq: Name 0005-implement-cecc-client-list-devices.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You folks include cecc-client in the binary package generated by debian/* so I figured I should too in the "official" debian package. But cecc-client --help and cecc-client --list-devices were //TODO so I did.