Verify Ultima VII Part Two: Serpent Isle + The Silver Seed#517
Open
tomojira wants to merge 1 commit intoPureDOS:mainfrom
Open
Verify Ultima VII Part Two: Serpent Isle + The Silver Seed#517tomojira wants to merge 1 commit intoPureDOS:mainfrom
tomojira wants to merge 1 commit intoPureDOS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first attempt at verifying one of the games in Unverified, using the questions we came up with a while back. Please let me know if there's anything more I should do!
Can DoDAT build the game from the disc image?
Yes, using Ultima Collection (USA) (Rerelease) (Redump).
Does the DOSZ run standalone?
Yes, but without sound at first. Run
INSTALL.EXEto configure sound and createSERPENT.CFG, which is included in the DOSC.A
DOS.YMLis included in the DOSZ to make the game playable with these settings:Actually, only
mem_ems: falseseemed strictly necessary, but sources online saymem_umb: falsetoo, so it was included just in case.The
DOS.YMLin the DOSC redundantly included these options again, so I removed them there in this PR.Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
Yes,
SETUP.EXEappears to be for Windows. I removed it in this PR.Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Yes, it uses CM-32L (new).
However, the
DOS.YMLwas still using the old.doszextension, so I updated it to.dosxin this PR.Does the game have General MIDI support?
No.
Is the game running at the correct speed? Is CPU year specified?
Yes,
cpu_year: 1993is set, and the game speed seems okay. The water at the beginning might look a little fast, but reducing as low as 1990 doesn't change it, and GOG doesn't use any lower than that (14000 cycles).Is the DOSC auto-running and skipping past any obstructions? Is it updated to use WAITMODECHANGE if possible?
The DOSC auto-runs
SERPENT.COM, butWAITMODECHANGEis not used since it skips a chunk of the intro. The game starts at 320x200 resolution regardless.Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No, though the game does create many small files in the
.pure.zipwhile playing.Does the DOSC have copy protection removed, if possible?
No, but the game does have copy protection according to PCGamingWiki - we overlooked this last time. I have added a patch to remove it to the DOSC - it affects the file
STATIC\USECODE.Can the game benefit from using CHDtoOGG?
No.
Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, the
DOS.YMLin the DOSZ already uses embedded data.Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Yes,
Ultima VII - Part Two - Serpent Isle + The Silver Seed (1993) (Origin Systems).ymlwas added.Have any official patches been applied, if necessary?
This CD-ROM version is already fully patched.
Have digital versions (Steam, GOG) been checked for matching?
Yes, GOG matches. The game is not on Steam.
Is the game set up to run with the best quality graphics options by default?
Not applicable.
For CD games, can the game be set up to run without a CD mounted?
Not applicable.
Do the file timestamps match the installation media?
Yes.
Have adequate installation instructions been provided to match any config files in the DOSZ?
Not applicable.
Summary of changes
DOS.YMLin DOSCSETUP.EXEfrom DOSZ.doszto.dosx