Fix host initialization and reconnect lifecycle#6
Open
uz0r wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several lifecycle issues in the PurrNet Dissonance adapter:
Serverplayer ID.ShouldStartpredicate for consistent editor, clone, build, and disabled-flag behavior.startServerAsHostfor the opt-in server-to-host promotion flow; normal role selection follows PurrNet's planned or actual host role.FindObjectOfTypeusage.Validation
Tested in Unity 6000.4 Multiplayer Play Mode 2.0.2 with PurrNet v1.20.0-beta.249 and Dissonance 9.0.9:
host/client connection, disconnect, reconnect, and server-to-host promotion.
Standalone and headless dedicated-server builds still need explicit validation.
Full notes can be checked here https://github.com/uz0r/PurrNet-Dissonance/blob/docs/fork-changes/ADAPTER-REFACTOR-NOTES.md
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.