refactor: remove unused should_profile and profile_log_likelihood_function#1208
Merged
refactor: remove unused should_profile and profile_log_likelihood_function#1208
Conversation
…ction The profiling config option was always false and the method was never overridden in any downstream project. Remove the dead code path from SearchUpdater, NonLinearSearch, and Analysis. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
should_profileconfig option andAnalysis.profile_log_likelihood_functionmethod. The config was alwaysfalseand the method was never overridden in any downstream project (PyAutoArray, PyAutoGalaxy, PyAutoLens). Also removes the dead call from the autofit_workspace tutorial and cleans upshould_profilefrom all workspace config files.Follow-up to #1205.
API Changes
Analysis.profile_log_likelihood_functionremoved — was a no-op stub, never overriddenshould_profileconfig option removed fromgeneral.yamlprofiling sectionNonLinearSearch.should_profileattribute removedSee full details below.
Test Plan
pytest test_autofit -x)should_profilelines removed)Full API Changes (for automation & release notes)
Removed
Analysis.profile_log_likelihood_function(paths, instance)— unused profiling hookNonLinearSearch.should_profile— bool attribute from configSearchUpdater.__init__should_profileparametergeneral.yamlprofiling.should_profileconfig keyMigration
No migration needed — the feature was always disabled (
false) and never overridden.🤖 Generated with Claude Code