feat(hamilton): complete TCP transport client on transport/tcp - #1195
Open
cmoscy wants to merge 5 commits into
Open
feat(hamilton): complete TCP transport client on transport/tcp#1195cmoscy wants to merge 5 commits into
cmoscy wants to merge 5 commits into
Conversation
Replace the thin post-PyLabRobot#1000 stub with the HOI/HARP session client, command layer, wire types, and introspection stack so Prep/Nimbus can build on it.
Python 3.9 binds asyncio.Lock to the current loop at Socket construction, so HamiltonTCPClient cannot be created in sync TestCase methods. Use IsolatedAsyncioTestCase for those cases.
rickwierenga
force-pushed
the
hamilton-tcp-transport
branch
from
August 16, 2026 06:01
612142c to
8627f84
Compare
Member
|
also it seems like we should have a background reading thread like the star has that reads all incoming commands and then matches them to the specific command that was sent |
Member
|
until we figure out concurrency on the tcp protocol (see the locking mechanism for the star), I think we should have a lock to force one command at a time |
Member
|
also is it possible to get rid of hasattr etc.? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Hamilton TCP/HOI client under
pylabrobot/hamilton/transport/tcp: protocol, wire types, introspection, error tables, and unit tests.Instrument-agnostic shared layer only — no Prep/Nimbus device peers. Prep (follow-up PR) builds on this.