Fix simulated STAR last LLD heights - #1200
Merged
Merged
Conversation
Member
|
thanks for the PR! @BioCam can you review/merge this? |
…ection Match the Google-style docstring shape of its hardware counterpart, `STARBackend.request_pip_height_last_lld`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
|
Thank you @VivienP ! Great addition to the simulation engine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
STARChatterboxBackend.request_pip_height_last_lld()to report theheights produced by simulated liquid-level detection instead of returning the
hardcoded
list(range(12)).The chatterbox now keeps a per-channel latch of the latest simulated absolute
LLD height.
_run_lld_on_channel_batch()updates that state using themeasurement it already computes, and
request_pip_height_last_lld()returns it.This keeps the simulated query consistent with the existing state-backed LLD
path without changing the public API.
Related to #934.
Tests
Added regression coverage for:
0.0probe_liquid_heights()Validation:
STAR_tests.py: 122 passed, 81 subtestslegacy/liquid_handling: 479 passed, 1 skipped, 101 subtests