fix(liquid-handling): report committed tip state from chatterbox sensors - #1207
Open
VivienP wants to merge 1 commit into
Open
fix(liquid-handling): report committed tip state from chatterbox sensors#1207VivienP wants to merge 1 commit into
VivienP wants to merge 1 commit into
Conversation
request_tip_presence used pending has_tip, so recovery committed failed pickups and drops. Add TipTracker.has_committed_tip and query that instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_tip_presence()read pendinghas_tip, so LiquidHandler error recovery committed failed pickups and drops.TipTracker.has_committed_tipand use it for simulated sleeve sensors (generic chatterbox and STAR chatterbox, including head96).get_tip()pending-state alignment). Hardware UNKNOWN/UNCERTAIN handling is out of scope.Test plan
python -m pytest pylabrobot/resources/tip_tracker_tests.py pylabrobot/legacy/liquid_handling/backends/chatterbox_tests.py pylabrobot/legacy/liquid_handling/liquid_handler_tests.py -q