Skip to content

Feat: allow nested stacked arrays#201

Open
mrava87 wants to merge 7 commits into
PyLops:mainfrom
mrava87:feat-nestedstacked
Open

Feat: allow nested stacked arrays#201
mrava87 wants to merge 7 commits into
PyLops:mainfrom
mrava87:feat-nestedstacked

Conversation

@mrava87

@mrava87 mrava87 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Motivation

This PR introduces support for nested StackedDistributedArray.

In other words, in the current setup one can stack multiple DistributedArray into a StackedDistributedArray. However as part of this effort to introduce support for distributed proximal operators and solvers in pylops-mpi, it turns out that in some scenarios one requires to created nested StackedDistributedArray, meaning that one of more elements of a StackedDistributedArray are StackedDistributedArray themselves.

Some changes are required for basic operations (eg +, -, *) to work and this PR provides them.

TO DO

  • Add NCCL tests
  • Add example

@mrava87 mrava87 self-assigned this Jun 22, 2026
@mrava87 mrava87 added the enhancement New feature or request label Jun 22, 2026
@mrava87 mrava87 mentioned this pull request Jun 22, 2026
@mrava87 mrava87 requested a review from rohanbabbar04 June 22, 2026 21:33
@mrava87

mrava87 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@rohanbabbar04 do you mind reviewing this 😄

@mrava87 mrava87 marked this pull request as ready for review June 23, 2026 17:46
@mrava87

mrava87 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@rohanbabbar04 interesting that the ubuntu mpich with 9 seems to take ages, not sure if it is related to the PR new tests... I can make a fake PR and see

Looks like also with no change to the codebase a few of the mpich/9 actions are slow #202

@rohanbabbar04

Copy link
Copy Markdown
Collaborator

@rohanbabbar04 interesting that the ubuntu mpich with 9 seems to take ages, not sure if it is related to the PR new tests... I can make a fake PR and see

I think it is because of the ISTA_FISTA tests we added, they seem to take much longer. Also, in general mpich with 9 is usually very slow as compared to the others.

@rohanbabbar04 rohanbabbar04 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just relaxed one test so that the GA doesn't crash 😅

Feel free to merge it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants