Skip to content

fix: correct typehint of SlashCommandGroup.__new__#3235

Open
AstreaTSS wants to merge 2 commits into
Pycord-Development:masterfrom
AstreaTSS:slashgroup-new-fix
Open

fix: correct typehint of SlashCommandGroup.__new__#3235
AstreaTSS wants to merge 2 commits into
Pycord-Development:masterfrom
AstreaTSS:slashgroup-new-fix

Conversation

@AstreaTSS
Copy link
Copy Markdown
Contributor

@AstreaTSS AstreaTSS commented May 23, 2026

Summary

A very simple PR changing the typehint of SlashCommandGroup.__new__ from SlashCommandGroup to Self, which allows subclasses of SlashCommandGroup to be typehinted correctly.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@AstreaTSS AstreaTSS requested review from a team and Dorukyum May 23, 2026 02:49
@AstreaTSS AstreaTSS requested a review from plun1331 May 23, 2026 02:49
@AstreaTSS AstreaTSS requested a review from a team as a code owner May 23, 2026 02:49
@AstreaTSS AstreaTSS requested review from Lulalaby and removed request for a team May 23, 2026 02:49
@github-project-automation github-project-automation Bot moved this to Todo in Pycord May 23, 2026
@pycord-app
Copy link
Copy Markdown

pycord-app Bot commented May 23, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3235/head:pr-3235
git checkout pr-3235

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3235/head

@AstreaTSS AstreaTSS requested a review from a team as a code owner May 23, 2026 02:52
@AstreaTSS AstreaTSS requested review from a team, Icebluewolf and VincentRPS May 23, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant