Skip to content

Adding (basic) LShaped support to generic cylinders#761

Open
tvalenciaz wants to merge 20 commits into
Pyomo:mainfrom
tvalenciaz:lsh_gen_cyl
Open

Adding (basic) LShaped support to generic cylinders#761
tvalenciaz wants to merge 20 commits into
Pyomo:mainfrom
tvalenciaz:lsh_gen_cyl

Conversation

@tvalenciaz

Copy link
Copy Markdown
Contributor

Adding an option to run an --lshaped-hub and --xhatlshaped xhatter to generic cylinders.
Also adding an example to the examples based on the tutorial under development.
A test was added to the generic_tester.py on farmer and the new "relief" example.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.98%. Comparing base (ca1984a) to head (e035730).

Files with missing lines Patch % Lines
mpisppy/utils/cfg_vanilla.py 90.90% 1 Missing ⚠️
mpisppy/utils/config.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   73.73%   73.98%   +0.24%     
==========================================
  Files         165      165              
  Lines       21121    21144      +23     
==========================================
+ Hits        15574    15643      +69     
+ Misses       5547     5501      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvalenciaz tvalenciaz marked this pull request as ready for review June 19, 2026 15:18
two-stage problems:

.. code-block:: bash

@DLWoodruff DLWoodruff Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why np 3 works here. It looks to me like there are two cylinders and you have not requested unbalanced ranks. But I guess it does work. In any event, there should be a test for this particular command, which could be in the run_all part 1 script or somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants