Adding (basic) LShaped support to generic cylinders#761
Open
tvalenciaz wants to merge 20 commits into
Open
Conversation
added 12 commits
March 26, 2026 17:01
… instead of scenario_denouement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
+ Coverage 73.73% 73.98% +0.24%
==========================================
Files 165 165
Lines 21121 21144 +23
==========================================
+ Hits 15574 15643 +69
+ Misses 5547 5501 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
added 8 commits
June 17, 2026 09:25
DLWoodruff
reviewed
Jun 19, 2026
| two-stage problems: | ||
|
|
||
| .. code-block:: bash | ||
|
|
Collaborator
There was a problem hiding this comment.
I don't understand why np 3 works here. It looks to me like there are two cylinders and you have not requested unbalanced ranks. But I guess it does work. In any event, there should be a test for this particular command, which could be in the run_all part 1 script or somewhere else.
DLWoodruff
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an option to run an
--lshaped-huband--xhatlshapedxhatter to generic cylinders.Also adding an example to the
examplesbased on the tutorial under development.A test was added to the
generic_tester.pyon farmer and the new "relief" example.