Cip 67 & 68 Support (continued from #297)#490
Closed
SamDelaney wants to merge 30 commits into
Closed
Conversation
…to bugfix/extended-cip8
…estring Bugfix/bytestring
…al/pycardano into feat/cip67-cip68
Feat/cip67 cip68
- Switched to TypedDicts for metadata classes - Added PlutusData wrapper class and tests
…dano into feat/cip67-cip68
Feat/cip67 cip68
…to feat/cip67-cip68
This was referenced Jun 1, 2026
Author
|
Closing in favor of theeldermillenial#4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the work done in #297 by @theeldermillenial and @Cat-Treat in hopes of closing it out. Happy to have it pulled into that PR if preferred, I just want to confirm the builds pass here.
Changes that are specific to this PR:
Merged w/ main
Add crc8 >=v0.1.0 to (confirmed works w/ 0.1.0, 0.2.0, 0.2.1)
Fix
IndefiniteListinitialization crash when wrappingIndefiniteFrozenListIndefiniteList.__init__would raiseAttributeError: 'IndefiniteFrozenList' object has no attribute 'data'when passed anIndefiniteFrozenList.UserList.__init__detects it as aUserListinstance and tries to copy via.data[:], butIndefiniteFrozenListinherits fromFrozenList(a C-extension list subclass) which stores items in the list itself, not in a.dataattribute.The fix converts
FrozenListinputs to a plainlistbefore delegating toUserList.__init__. This surfaces in CIP-68 datum round-trip serialization, where the CBOR decoder produces anIndefiniteFrozenListthat is then wrapped in a newIndefiniteListduringto_shallow_primitive.