Improve PQK tutorial, closes 5604 - #5608
Open
Soyoung Shin (0sophy1) wants to merge 8 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
One or more of the following people are relevant to this code:
|
6 tasks
Henry Zou (henryzou50)
added a commit
to henryzou50/documentation
that referenced
this pull request
Sep 8, 2026
The four CSVs under datasets/tutorials/pqk/ had a UTF-8 BOM, CRLF line endings, and every line of train_data.csv and test_data.csv wrapped in double quotes. pandas read each row as a single string column of NaNs, and np.loadtxt rejected the BOM. The tutorial's stored output (14:0:15) shows the author's original data parsed correctly, so the files were mangled on export. Rewrite them as plain UTF-8 with LF line endings and no wrapping quotes. Values are unchanged. The notebook-side fixes (download path, projections file names, urllib instead of wget) are handled in Qiskit#5608. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Henry Zou (henryzou50)
added a commit
to henryzou50/documentation
that referenced
this pull request
Sep 8, 2026
The four CSVs under datasets/tutorials/pqk/ had a UTF-8 BOM, CRLF line endings, and every line of train_data.csv and test_data.csv wrapped in double quotes. pandas read each row as a single string column of NaNs, and np.loadtxt rejected the BOM. The tutorial's stored output (14:0:15) shows the author's original data parsed correctly, so the files were mangled on export. Rewrite them as plain UTF-8 with LF line endings and no wrapping quotes. Values are unchanged. The notebook-side fixes (download path, projections file names, urllib instead of wget) are handled in Qiskit#5608.
6 tasks
Soyoung Shin (0sophy1)
requested review from
abbycross and
Henry Zou (henryzou50)
September 10, 2026 20:39
Henry Zou (henryzou50)
previously approved these changes
Sep 10, 2026
Henry Zou (henryzou50)
left a comment
Henry Zou (henryzou50)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, Sophy! I just tested it and LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgetshell commands withurllib.request; works anywhere without external tools.projections_train.csvandprojections_test.csvto the download list.dir_rootnow points to the actual download directory instead of"./"..csv(not nonexistent.txt) with a header-aware helper function.