fix(github): store owner/repo as channelId so webhook registration works#336
Open
9technologygroup wants to merge 1 commit into
Open
fix(github): store owner/repo as channelId so webhook registration works#3369technologygroup wants to merge 1 commit into
9technologygroup wants to merge 1 commit into
Conversation
The repository <SelectItem> used the numeric repo id as its value, so config.channelId was saved as e.g. "123456789" instead of "owner/repo". Webhook registration builds https://api.github.com/repos/${channelId}/hooks, which GitHub then parses as /repos/{owner}/{repo} and returns 404 (documentation_url: repos#update-a-repository). Use repo.fullName ("owner/repo") as the select value so channelId round-trips correctly, matching what the webhook and issue-sync code expect.
|
Muhammad Ibrahim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Github Status sync not working. The repository used the numeric repo id as its value, so config.channelId was saved as e.g. "123456789" instead of "owner/repo". Webhook registration builds https://api.github.com/repos/${channelId}/hooks, which GitHub then parses as /repos/{owner}/{repo} and returns
404 (documentation_url: repos#update-a-repository).Use repo.fullName ("owner/repo") as the select value so channelId round-trips correctly, matching what the webhook and issue-sync code expect.