Align QuiverQuantCongressUniverse Python stub with sibling Quiver universes#5
Merged
DerekMelchin merged 1 commit intoMay 8, 2026
Conversation
…verses Hoist QuiverCongressDataPoint per-row fields onto QuiverQuantCongressUniverse and emit instances of the universe class itself from Reader, matching the pattern used by QuiverInsiderTradingUniverse, QuiverLobbyingUniverse, QuiverCNBCsUniverse, and QuiverGovernmentContractUniverse. Closes QuantConnect#4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuiverQuantCongressUniversewas the onlyQuiver*Universewhose Python stub did not expose its per-row data-point fields (amount,transaction,representative, ...) on the universe class itself, because in C# it inherited fromQuiverCongressand emittedQuiverCongressDataPointinstances fromReaderrather than instances of itself.QuiverInsiderTradingUniverse,QuiverLobbyingUniverse,QuiverCNBCsUniverse, andQuiverGovernmentContractUniverse: the universe now inheritsBaseDataCollectiondirectly, the per-row fields are declared on it, andReader/CloneemitQuiverQuantCongressUniverseinstances.QuiverCongressDataPointandQuiverCongressare unchanged — they still serve the non-universe data path and the data downloader.OfType<QuiverCongressDataPoint>()cast it previously needed; the Python sample was already cast-free and remains so.Readeroutput now asserts onQuiverQuantCongressUniverseinstead ofQuiverCongressDataPoint.Closes #4.
Generated Python stub diff
The following diff is from
quantconnect-stubs-generatorand shows that the universe class now exposes the per-row fields directly, matching its siblings:Test plan
dotnet test tests/Tests.csproj— 28/28 pass, includingQuiverCongressTests.UniverseReaderTestwhich now asserts onQuiverQuantCongressUniverseinstances.mypy --strictto confirm theattr-definederrors quoted in the issue are gone.