Skip to content

preview-netlify, preview-cloudflare: install the deploy CLI only on pull_request runs #193

Description

@quantecon-services

This is the #92 Phase 1 item "gate both preview actions' CLI installs on pull_request". #92 handed it to #105, but #105 closed on 2026-09-24 (shipped in v0.12.0) without it, so nothing tracked it.

What's wrong. On main @ 64aeb2f:

  • Both Install … CLI steps (preview-netlify/action.yml:56-58, preview-cloudflare/action.yml:68-70) run on if: steps.check-trust.outputs.skip != 'true' alone.
  • The deploy steps they feed (preview-netlify/action.yml:92-95, and the matching step in preview-cloudflare) also require github.event_name == 'pull_request'.

So a workflow_dispatch run, which both current consumers allow, spends time on npm ci of the pinned CLI and then skips the deploy. #92 measured the install at roughly 25–45 s.

Fix.

Related: #143, item 2, the release-gate spike. It checks the same pull_request gates, from the question of whether a non-PR gate run is silently green.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprovement to existing content or functionality

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions