Conversation
The GitHub Actions Pages deploy that publish-gh-pages uses ignores a CNAME file, so the input never set the custom domain: Settings → Pages does, and it already holds continuous-time-mcs.quantecon.org. From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes it (QuantEcon/actions#109, QuantEcon/actions#110). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for sparkly-moxie-de1f0e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for adorable-cucurucho-69162b ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a straightforward workflow input removal with a clarifying comment and does not alter deploy behavior.
Review effort: Lite
Findings: None
What changed in this PR
This PR updates the GitHub Pages publish workflow to stop passing the deprecated/ineffective cname input to quantecon/actions/publish-gh-pages, since the site’s custom domain is configured via the repository’s Settings → Pages and not via a CNAME file produced during the workflow.
Changes:
- Remove the
cname: continuous-time-mcs.quantecon.orginput from thepublish-gh-pagesaction invocation. - Add an inline comment documenting where the custom domain is configured and why the
cnameinput has no effect.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Removes the unused cname input and documents that the custom domain is managed in GitHub Pages settings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
publish-gh-pagesdeploys through GitHub Actions Pages, which ignores aCNAMEfile, so thecname:input has never set the custom domain. Settings → Pages does, and it holdscontinuous-time-mcs.quantecon.org(checked withgh api repos/QuantEcon/continuous_time_mcs/pages:cname: continuous-time-mcs.quantecon.org,build_type: workflow,https_enforced: true). From QuantEcon/actions v0.12.0 the action warns on every deploy that still passes the input. This removes it and leaves a comment saying where the domain lives.No effect on the published site. The only other thing the input did was write a
CNAMEfile into the build directory, so the release HTML archive stops carrying one; nothing reads it when serving.This workflow runs on a
publish*tag, so this PR's CI does not exercise it. The check is the next real publish after merge: once Dependabot moves this repo from@v0.11.1to v0.12.0, publish runs would otherwise start showing thecnamewarning; with this change they won't, and the site should still serve oncontinuous-time-mcs.quantecon.org.Follow-up from QuantEcon/actions#110.
Assisted-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code