Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Let's try being a little more flexible with compat...
kshyatt
force-pushed
the
ksh/mps
branch
2 times, most recently
from
1e62663 to
dcb2294
Compare
| @assert !isnothing(I) | ||
| @views dst_dense .= src_dense[:, I] | ||
| # deal with the case where the output is not in-place | ||
| dst_dense === dst_block || copyto!(dst_block, dst_dense) |
There was a problem hiding this comment.
Just out of curiosity, is this ever in-place?
I guess the dst_dense always comes from a similar_dense, which allocates a fresh array?
There was a problem hiding this comment.
I guess in theory, it could be? For now I agree it's always out of place
| if eltype(t) === T && typeof(space(t)) === typeof(P) | ||
| return T | ||
| elseif isconcretetype(T) | ||
| elseif isconcretetype(T) || T isa Union |
There was a problem hiding this comment.
Nice catch! this is probably already solving a lot of issues?
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Left the one comment open, feel free to pick whichever you like and merge!
(Maybe we can already bump the patch version?)
|
@kshyatt can you also bump the patch version and release? |
2 participants
OK, I think we do actually need the GPU-specific
copyto!for things to work. We also need some explicit promotion strategies due to the extremely annoying wayAbstractTensorMapstorage types work 😸