fix select exception fdset clearing#1373
Open
russellromney wants to merge 1 commit into
Open
Conversation
df4b215 to
24a285d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
select(2)fdset handling when an exception event does not occur.DoSelect()correctly clearsreadfdsandwritefdsentries when their requested events are absent, but the exception-fdset branch accidentally clearedwritefdsinstead ofexceptfds:This leaves the file descriptor incorrectly set in
exceptfds.Regression Test
Adds
test/c/select_except_connect.cand includes it inmake clean, a minimal loopback TCP regression:connect()select()with read/write/exception fdsetswritefds, notexceptfds, andSO_ERROR == 0Validation
Local/native control:
Quark red/green on a DO droplet with only qkernel swapped:
Unpatched qkernel:
Patched qkernel:
runccontrol: