device busy attribute to prevent attaching devices whose children are in use - #59
Open
piotrbartman wants to merge 2 commits into
Open
device busy attribute to prevent attaching devices whose children are in use#59piotrbartman wants to merge 2 commits into
piotrbartman wants to merge 2 commits into
Conversation
read /qubes-usb-devices/{id}/busy (set by children) from QubesDB and enforce it on USB attach
pre-attach raises QubesValueError if the device is busy.
USB extension needs its own read of the busy flag + its own attach-refusal
add tests
if one of subdevices are locally used (e.g. in sys-usb) the parent is considered busy
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026071723-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 25 fixed
Unstable testsDetails
Performance TestsPerformance degradation:19 performance degradations
Remaining performance tests:91 tests
|
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add busy mechanism as the BlockDevice bt for USBDevice:, see: QubesOS/qubes-core-admin/pull/840
a USB device is refused for attachment while one of its exposed block sub-devices is used.
USBDevice.busyreads/qubes-usb-devices/<id>/busythe same way as the block side; mark_busy() writes/clears it.qbool_untrusted_busy: absent key = free, anything else = busy, no fancy parsing, since as for now never wrote a false literal anyway (we remove the key instead).