Skip to content

[GRDM-57855] Prevent auto-submitting Project/Collection when confirming Japanese IME input with Enter#184

Draft
ndnhat1 wants to merge 2 commits into
developfrom
feature/nii_grdm_202603_step9/2.2_improve_project_name_input
Draft

[GRDM-57855] Prevent auto-submitting Project/Collection when confirming Japanese IME input with Enter#184
ndnhat1 wants to merge 2 commits into
developfrom
feature/nii_grdm_202603_step9/2.2_improve_project_name_input

Conversation

@ndnhat1

@ndnhat1 ndnhat1 commented May 29, 2026

Copy link
Copy Markdown
  • Ticket: [57855]
  • Feature flag: n/a

Purpose

The purpose of these changes is to fix an issue where pressing the Enter key to confirm Japanese IME (Input Method Editor) composition unintentionally triggers the creation of a Project. This fix ensures that users can completely type and confirm their Japanese input without the form submitting prematurely and creating entities with incomplete names.

Summary of Changes

  • lib/osf-components/addon/components/new-project-modal/component.ts: Added handleKeydown method.
  • lib/osf-components/addon/components/new-project-modal/template.hbs: Updated to use the new keydown handler.
  • tests/integration/components/new-project-modal/component-test.ts: Added new test cases for Enter key vs IME composition, improved mocks and setup.

Side Effects

QA Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants