add time-zone user setting#43
Open
Wit-MKW wants to merge 12 commits into
Open
Conversation
removed an errant semicolon.
in fact, it's nothing. i need to keep track of my own column names.
i kept the ID `pokemon-crystal-settings` just because i feel like changing it might unnecessarily break something.
cue laugh track. gods, i can be silly sometimes.
just in case Japan implements DST or splits its time zones or something else. if some of them have to be UTC+9, we might as well add the option to make them all UTC+9.
Collaborator
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds a
timezonecolumn to thesys_userstable, which takes a tz database string & defaults toAsia/Tokyo. note that this is only to be used for times that are merely shown to the player (for example, the update time on a leaderboard); times that are actually used by game logic should be in the time zone (GMT or JST) that said logic expects.