Skip to content

[Revert][WS2][GEMM][PR4]: add PR4 forward integration validation for Qwen3-8B (TP=2, CP=2) - #282

Open
Flink-ddd wants to merge 1 commit into
RL-Align:mainfrom
Flink-ddd:revert-accidental-merge
Open

[Revert][WS2][GEMM][PR4]: add PR4 forward integration validation for Qwen3-8B (TP=2, CP=2)#282
Flink-ddd wants to merge 1 commit into
RL-Align:mainfrom
Flink-ddd:revert-accidental-merge

Conversation

@Flink-ddd

@Flink-ddd Flink-ddd commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR introduces the WS2 PR4 forward integration validation test for Qwen3-8B, verifying the execution of the SwiGLUSM90Op within a distributed topology.

Note: This PR depends on the underlying SM90 operator introduced in PR #258. CI will pass once that PR is merged.

The test implements a strict 4-rank topology to validate the following requirements:

Creates TP groups [0, 1], [2, 3] and CP groups [0, 2], [1, 3] in the test launcher.

Runs Gate and Up local det_gemm_fwd independently on both CP shards.

Executes the PR3 Down forward operator on both TP groups.

Explicitly marks InterNode TP, TP=4+, and uneven shards as NOT COVERED.

Hardware Validation

The validation script was successfully executed on a bare-metal node equipped with 8x NVIDIA H200 SXM GPUs.

Below is the execution log confirming the topological setup, successful pipeline assembly, and adherence to the defined accuracy thresholds (atol/rtol) without numerical drift.

INFO 08-05 15:25:23 [RL-Kernel]: Successfully linked to the SM90 SwiGLU forward kernel.

=== Starting WS2 PR4 Forward Validation ===
INFO 08-05 15:25:24 [RL-Kernel]: Successfully linked to the SM90 SwiGLU forward kernel.
INFO 08-05 15:25:24 [RL-Kernel]: Successfully linked to the SM90 SwiGLU forward kernel.
INFO 08-05 15:25:24 [RL-Kernel]: Successfully linked to the SM90 SwiGLU forward kernel.
[Rank 0] Pipeline Assembled & Validated. Output Shape: torch.Size([128, 4096])
[Rank 0] Validation Passed! (atol=0.05, rtol=0.02)

=== WS2 Topology & Conformance Report ===
COVERED:
  - 4 ranks topology (TP=2, CP=2)
  - two IntraNode TP AllReduce groups
  - NCCL Version: (2, 29, 7)
  - Dtype: torch.bfloat16 arithmetic and reductions
NOT COVERED:
  - InterNode TP, TP=4+, and uneven shards
  - DP>1 or a combined DP x CP gradient group
=========================================

Summary by CodeRabbit

  • Tests
    • Removed the Qwen3-8B WS2 PR4 forward integration test and its associated validation workflow.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 629dc0de-61d2-40a3-9c0d-47ca6ce7de19

📥 Commits

Reviewing files that changed from the base of the PR and between 2e08ef6 and 3117474.

📒 Files selected for processing (1)
  • tests/test_qwen3_fwd_integration.py
💤 Files with no reviewable changes (1)
  • tests/test_qwen3_fwd_integration.py

📝 Walkthrough

Walkthrough

The PR removes the Qwen3-8B WS2 PR4 forward integration test and its topology, validation, reporting, cleanup, and entry-point code.

Changes

Cohort / File(s) Summary
Qwen3 forward test removal
tests/test_qwen3_fwd_integration.py
Deletes the 4-rank NCCL setup, deterministic test pipeline, FP32 comparison, reporting, process-group cleanup, and executable entry point.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: frank-2077, inaniloquentee, bitborne

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the revert of the Qwen3-8B PR4 forward integration validation for TP=2 and CP=2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant