[Revert][WS2][GEMM][PR4]: add PR4 forward integration validation for Qwen3-8B (TP=2, CP=2) - #282
Open
Flink-ddd wants to merge 1 commit into
Open
[Revert][WS2][GEMM][PR4]: add PR4 forward integration validation for Qwen3-8B (TP=2, CP=2)#282Flink-ddd wants to merge 1 commit into
Flink-ddd wants to merge 1 commit into
Conversation
…B (TP=2, CP=2)" This reverts commit 2e08ef6.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR removes the Qwen3-8B WS2 PR4 forward integration test and its topology, validation, reporting, cleanup, and entry-point code. Changes
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the WS2 PR4 forward integration validation test for Qwen3-8B, verifying the execution of the SwiGLUSM90Op within a distributed topology.
Note: This PR depends on the underlying SM90 operator introduced in PR #258. CI will pass once that PR is merged.
The test implements a strict 4-rank topology to validate the following requirements:
Creates TP groups [0, 1], [2, 3] and CP groups [0, 2], [1, 3] in the test launcher.
Runs Gate and Up local det_gemm_fwd independently on both CP shards.
Executes the PR3 Down forward operator on both TP groups.
Explicitly marks InterNode TP, TP=4+, and uneven shards as NOT COVERED.
Hardware Validation
The validation script was successfully executed on a bare-metal node equipped with 8x NVIDIA H200 SXM GPUs.
Below is the execution log confirming the topological setup, successful pipeline assembly, and adherence to the defined accuracy thresholds (atol/rtol) without numerical drift.
Summary by CodeRabbit