feat(ui): Add region mapping disclaimer - #894
Conversation
Expected version change and release notes:1.16.0-dev.11 (v1.16.0-dev.10...feat/geography-region-disclaimer ) (2026-08-17T12:20 UTC)Features
Other
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-894.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Adds a standardized disclaimer clarifying that region→country mappings come from the pathway model and are not political statements, addressing Issue #800 across key UI surfaces.
Changes:
- Introduces a shared
REGION_MAPPING_DISCLAIMERconstant as the single source of truth for disclaimer text. - Displays the disclaimer on the Resources Methodology page and in the Geography filter dropdown (via a new dropdown footer).
- Extends the Pathway Detail “Geographies” tooltip to include the disclaimer and adds targeted UI tests for two of the three placements.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/geographyUtils.ts | Adds shared REGION_MAPPING_DISCLAIMER constant for reuse across UI. |
| src/pages/resources/ResourcesMethodologyPage.tsx | Updates the Regions note to include the shared disclaimer text. |
| src/pages/resources/ResourcesMethodologyPage.test.tsx | Adds tests ensuring the disclaimer and existing territorial-claims text render correctly. |
| src/pages/PathwayDetailPage.tsx | Appends the disclaimer to the Geographies tooltip content. |
| src/components/SearchSection.tsx | Adds the disclaimer as a footnote under the Geography facet dropdown. |
| src/components/SearchSection.test.tsx | Tests that only the Geography dropdown shows the disclaimer footnote. |
| src/components/MultiSelectDropdown.tsx | Threads a new footer prop through to the dropdown shell. |
| src/components/DropdownFacetShell.tsx | Implements optional dropdown footer rendering for facet panels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-894.westus2.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-894.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/utils/geographyUtils.ts:12
REGION_MAPPING_DISCLAIMERis exported fromgeographyUtils.ts, which has module-level side effects and heavy deps (i18n-iso-countries+registerLocale). Importing this constant into routes like SearchSection/ResourcesMethodologyPage will pull that bundle + execute the side effect even when no country-name utilities are used, increasing route chunk size unnecessarily.
Consider moving this string to a lightweight constants module (e.g. src/utils/disclaimers.ts) and importing it from there in the UI, optionally re-exporting it from geographyUtils.ts for convenience.
// Approved wording from #800 (2026-08-10). Single source of truth for the
// region-mapping disclaimer, rendered on the methodology page, in the detail-page
// geography tooltip, and under the Geography filter dropdown — the three places a
// user meets a region→country mapping.
export const REGION_MAPPING_DISCLAIMER =
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-894.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/pages/resources/ResourcesMethodologyPage.tsx:3
REGION_MAPPING_DISCLAIMERis imported fromgeographyUtils, which has a module-leveli18n-iso-countries+ locale JSON import/registration. Pulling that entire module into the Methodology page just to render a single copy string is likely to increase the page bundle unnecessarily. Consider moving the disclaimer text into a lightweight constants/copy module (and optionally re-export it fromgeographyUtils), so pages that only need the string don’t also pay for the country-name machinery.
import React, { useId, useState } from "react";
import { Link } from "react-router";
import { REGION_MAPPING_DISCLAIMER } from "../../utils/geographyUtils";
src/components/MultiSelectDropdown.tsx:100
DropdownFacetShelltypessummaryas astring, butMultiSelectDropdownpassesnumber | null(current.length/null). This is a real type mismatch (and can become a compile error if/when type-checking is enforced). Convert the value to a string at the call site (or widenDropdownFacetShell’ssummarytype) so the props contract is consistent.
summary={summary}
onClear={clear}
menuWidthClassName={menuWidthClassName}
triggerMinWidthClassName={triggerMinWidthClassName}
footer={footer}
|
We should probably add this to the info hover on the comparison page too @AlexAxthelm |
jacobvjk
left a comment
jacobvjk
left a comment
There was a problem hiding this comment.
This is all functional and as expected, but we should add the disclaimer to the ComparisonPage (i) hover as well, not just to the DetailsPage
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-894.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/pages/resources/ResourcesMethodologyPage.tsx:3
ResourcesMethodologyPagenow importsREGION_MAPPING_DISCLAIMERfromgeographyUtils, which has module-level side effects (countries.registerLocale(en)) and pulls ini18n-iso-countries. Since this page only needs static copy, consider moving the disclaimer to a lightweight constants module (or re-exporting from one) to avoid coupling UI copy to a heavy util with side effects.
import React, { useId, useState } from "react";
import { Link } from "react-router";
import { REGION_MAPPING_DISCLAIMER } from "../../utils/geographyUtils";
src/pages/ComparisonPage.disclaimer.test.tsx:85
- Typo/inconsistent reference: this suite is for #800 (and the file header comment says #800), but the
describeblock says#894, which can confuse future searches and traceability.
describe("ComparisonPage — geography disclaimer (#894)", () => {
| geographyLabel, | ||
| geographyVariant, | ||
| normalizeGeography, | ||
| REGION_MAPPING_DISCLAIMER, |
There was a problem hiding this comment.
@AlexAxthelm I added the same behavior to the Comparison page, this resolves my requested change. I also added a test for this. If we care to deduplicate the behavior, we could do that too
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-894.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/pages/ComparisonPage.tsx:352
- The PR description says the disclaimer surfaces in 3 places (methodology page, detail page, geography filter), but this change also adds it to the ComparisonPage “Geographies” tooltip. If this is intentional, the PR description should be updated to include this additional surface; if it’s not intended, the disclaimer should be removed here to match the stated scope.
tooltip={
<>
<span className="block">
{GEOGRAPHY_AVAILABILITY_TOOLTIP}
</span>
<span className="mt-2 block italic">
{REGION_MAPPING_DISCLAIMER}
</span>
</>
src/pages/ComparisonPage.disclaimer.test.tsx:85
- The test suite label references “#894”, but this file’s own header comment and the PR context are about #800. This mismatch makes it harder to trace why the test exists.
describe("ComparisonPage — geography disclaimer (#894)", () => {
Adds the region-mapping disclaimer agreed on #800:
It lives in one place —
REGION_MAPPING_DISCLAIMERinsrc/utils/geographyUtils.ts— and surfaces wherever a user meets a region→country mapping:footerslot onDropdownFacetShell→MultiSelectDropdown; it's guarded onfooter &&, so every other facet renders exactly as before.Copy and placement only — no behavior change.
Closes #800. Part of #783 / epic #860.
Testing
422 tests pass. New coverage:
ResourcesMethodologyPage.test.tsx(the page had no test file) asserts the disclaimer and the territorial-claims sentence each appear exactly once, guarding against a second near-duplicate note;SearchSection.test.tsxgains two tests asserting the footnote appears under Geography and not under other facets.Manually, in PR Preview:
/pathway/IEA-APS-2024) — hover the ⓘ next to "Geographies": availability text, then the disclaimer in italics below it.Note for reviewers
This can merge before or after #895 — the two branches both touch
PathwayDetailPage.tsxandgeographyUtils.ts, but in non-overlapping hunks. Verified by test-merging both directions: clean, identical result tree, and the merged combination passes the suite and lint.