Add Primus pretrain integration (primus_pretrain)#146
Open
coketaste wants to merge 9 commits into
Open
Conversation
- Add scripts/Primus submodule (AMD-AGI/Primus) and docker/primus.ubuntu.amd.Dockerfile - Add scripts/primus_pretrain (run.sh, get_models_json.py, extract_primus_perf.py) - Register primus_pretrain in models.json before existing primus_pyt_* entries - Un-ignore tracked perf manifests and models.json in .gitignore run.sh: resolve local submodule via ../Primus (sibling of primus_pretrain under scripts/).
coketaste
requested review from
Rohan138,
amathews-amd and
ppalaniappan-amd
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Integrates Primus pretraining into the MAD/madengine workflow by adding a dedicated runner script bundle, a new Primus-based Docker image, and registering a new primus_pretrain model entry so Primus pretrain jobs can be launched consistently across environments.
Changes:
- Added
scripts/primus_pretrain/wrappers to run Primus pretrain and emitmultiple_resultsperf CSV. - Added a new
docker/primus.ubuntu.amd.Dockerfileand registeredprimus_pretraininmodels.json. - Added
scripts/Primusas a git submodule and adjusted.gitignoreto track key perf/model manifests.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/primus_pretrain/run.sh |
Wrapper to resolve Primus root/config, run pretrain, and post-process perf metrics. |
scripts/primus_pretrain/get_models_json.py |
Optional discovery of Primus configs as runnable models via globbing. |
scripts/primus_pretrain/extract_primus_perf.py |
Parses training logs and writes a multiple_results CSV. |
models.json |
Registers primus_pretrain ahead of existing Primus PyTorch training entries. |
docker/primus.ubuntu.amd.Dockerfile |
Defines a Primus image intended to bake in the Primus submodule. |
.gitmodules |
Adds the scripts/Primus submodule definition. |
.gitignore |
Stops ignoring tracked perf manifests and models.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- README.md: clarify Docker build and discovery notes as madengine-only; document that tools/run_models.py is unsupported for primus_pretrain due to ./docker build context incompatibility - models.json: add multiple_results: primus_perf_output.csv to primus_pretrain so the runner picks up tps/tflops/mfu from the CSV - run.sh: validate PRIMUS_ROOT path when set via env var; use set +e/-e around run_pretrain.sh so exitcode is captured correctly; fix comment on CSV row format - get_models_json.py: pass recursive=True to glob so CONFIGS_GLOB pattern matches nested YAML paths correctly Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Aligns with the schema documented in README.md and the convention used by all other entries in models.json. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Comment on lines
+90
to
+92
| if [[ -f "$LOG_PATH" ]]; then | ||
| python3 "$RUN_DIR/extract_primus_perf.py" "$LOG_PATH" "$RUN_DIR/primus_perf_output.csv" || true | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run.sh: resolve local submodule via ../Primus (sibling of primus_pretrain under scripts/).