Fix p48107 z3109 hierarchy mappings - #179
Conversation
louisaserpe
left a comment
There was a problem hiding this comment.
Thanks for contributing to the repo! Although this is a very small change, it would be great if you could add a few figures comparing main to your branch in the PR text . The ReEDS documentation has some instructions on how to use a python helper script the team developed to do this.
| p48075,TX,texas,ERCOT,ERCOT,ERCOT,ERCOT | ||
| p48101,TX,texas,ERCOT,ERCOT,ERCOT,ERCOT | ||
| p48107,TX,eastern,SPP,SPP,SPP_South,SPP | ||
| p48107,TX,eastern,SPP,SPP,SPP,SPP |
There was a problem hiding this comment.
I didn't mention this in #155, but the transgrp column for this row also needs to be updated from SPP to SPP_South. Would you be willing to add this change to your PR?
There was a problem hiding this comment.
Done, thank you for the detailed infromation. I updated p48107 to transgrp=SPP_South and nercr=SPP, and added main, branch, and difference maps to the PR description.
There was a problem hiding this comment.
One note on CI: the previous run failed because the Linux runner received a GAMS license with the wrong platform code, so it appears unrelated to this CSV change. The new run is marked action_required and has not started. Could you approve it and check whether the Linux GAMS license needs to be updated?
acb2f66 to
04cbe2e
Compare
Moving p48107 into the SPP_South transgrp changes the county set that defines SPP_South, and its md5 identifier along with it, so the existing SPP_South rows in itl_NARIS.csv no longer match. It also empties the single-county SPP transgrp. Drop the SPP~~SPP_South interface and re-key the four SPP_South ITLs to the new identifier. p48107 only connects to SPP_South counties, so the MISO and SPP_North limits are carried over unchanged.
|
The run on
All 26 z3109 transgrp interfaces and 6,864 r-level interfaces now resolve, and the other eight zone sets are unchanged. The @patrickbrown4 per the transmission contact list. |
| b58d220cfbab796fd585a74aca120d9f,1960b99def1a13feb78f50b29ce7ca6d,4049.1,3231.1 | ||
| 8118e512d9fd831209306eefc5413d00,1960b99def1a13feb78f50b29ce7ca6d,2720.7,2671.8 | ||
| b6459abf9bf881b24677402779f56188,1960b99def1a13feb78f50b29ce7ca6d,960.0,1026.0 | ||
| f274e3c309643ec75c40f961c2db5865,1960b99def1a13feb78f50b29ce7ca6d,2063.2,2131.3 |
There was a problem hiding this comment.
These need to be recalculated rather than duplicated. I'll rerun them and push the updated values.
Summary
Fix the
p48107mappings ininputs/zones/z3109/hierarchy.csv:transgrp:SPPtoSPP_Southnercr:SPP_SouthtoSPPThis aligns Crosby County with other Texas SPP counties and prevents the PRM broadcast
KeyError.Issues resolved
Closes #155.
Comparison
Main
PR #179
Difference
Only
p48107changes.Validation, testing, and comparison report(s)
p48107now matchesTX_PANininputs/zones/z90/hierarchy.csv, the only other zone set that resolves Crosby County on its own. The one-countySPPtransgrp and theSPP_Southnercr were unique to z3109.inputs/reserves/prm_annual.csvcovers exactly the 15nercrvalues in z3109 after the change, so both PRM scenarios broadcast for all 3,109 regions.transgrpchange alters the md5 that keysSPP_Southinitl_NARIS.csv, which brokeget_itls(level='transgrp')on04cbe2e;6864ee6updates the z3109 interface and ITL data to match. All 233 transgrp interfaces across the nine zone sets and all 6,864 z3109 r-level interfaces resolve. Details in the comment below.Checklist for author
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Yes. Codex and Claude Code assisted with reviewing the issue, checking the change against the other zone sets, and diagnosing the CI failure. I reviewed the diff, the figures, and the diagnosis.