Enable electrochem auto-selection for charged reactive species - #3009
Merged
Merged
Conversation
Copilot
AI
changed the title
Improve auto electrochem detection for charged species
Enable electrochem auto-selection for charged reactive species
Sep 14, 2026
Copilot created this pull request from a session on behalf of
rwest
September 14, 2026 15:45
View session
rwest
reviewed
Sep 14, 2026
rwest
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but it's doing exactly what I told it to do in the prompt, so I'm not an independent reviewer. Someone else should approve.
rwest
marked this pull request as ready for review
September 14, 2026 15:50
Co-authored-by: rwest <93807+rwest@users.noreply.github.com>
JacksonBurns
force-pushed
the
copilot/add-electrochemistry-trigger
branch
from
September 14, 2026 20:02
2cf315a to
e724a8d
Compare
JacksonBurns
enabled auto-merge
September 14, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autolibrary selection currently enables electrochemistry only viaELECTROCHEM_ELEMENTS(currently Li), so charged CO2RR inputs can miss electrochem libraries/families. This change broadens detection to include ionic chemistry while preserving existing element-based behavior.Detection logic (
rmgpy/data/auto_database.py)detect_chemistry(), markhas_electrochemwhen any reactive initial species has non-zero net charge.Behavioral invariant
has_electrochemis now true if either condition is true:ELECTROCHEM_ELEMENTS).Targeted coverage (
test/rmgpy/data/autoDatabaseTest.py)[H+]).[Li]).