Skip to content

fix: truncate long image filenames when saving to prevent ENAMETOOLONG #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibrahim-iqbal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: truncate long image filenames when saving to prevent ENAMETOOLONG #1324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions app/src/main/java/me/ash/reader/infrastructure/android/AndroidImageDownloader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ class AndroidImageDownloader @Inject constructor(
Request.Builder().url(imageUrl).build().runCatching {
okHttpClient.newCall(this).execute().run {

val fileName = URLUtil.guessFileName(
imageUrl, header("Content-Disposition"), body.contentType()?.toString()
val fileName = sanitizeFileName(
URLUtil.guessFileName(
imageUrl, header("Content-Disposition"), body.contentType()?.toString()
)
)

val relativePath =
Expand Down Expand Up @@ -90,6 +92,15 @@ class AndroidImageDownloader @Inject constructor(

}

private fun sanitizeFileName(fileName: String): String {
if (fileName.length <= MAX_FILENAME_LENGTH) return fileName
val dot = fileName.lastIndexOf('.')
val ext = if (dot > 0 && fileName.length - dot in 2..10) fileName.substring(dot) else ""
val base = if (ext.isEmpty()) fileName else fileName.substring(0, dot)
val maxBaseLength = (MAX_FILENAME_LENGTH - ext.length).coerceAtLeast(1)
return base.take(maxBaseLength) + ext
}

@DeprecatedSinceApi(29)
private fun Response.saveImageForAndroidP(
fileName: String,
Expand All @@ -109,4 +120,8 @@ class AndroidImageDownloader @Inject constructor(

return contentUri
}

private companion object {
const val MAX_FILENAME_LENGTH = 200
}
}
Loading