Skip to content

Improve handling of custom fluids in tank renderers - #837

Open
matelemons wants to merge 1 commit into
Rearth:1.21from
matelemons:1.21
Open

Improve handling of custom fluids in tank renderers#837
matelemons wants to merge 1 commit into
Rearth:1.21from
matelemons:1.21

Conversation

@matelemons

Copy link
Copy Markdown

Description

This PR changes tank renderers to use FluidStack instead of Fluid in order to tint the fluid element. This is because it seems like some mods only override the FluidStack variant of getTintColor (most notably, Create: Dragons Plus and its liquid dyes). As far as I'm aware there's no downside to doing it this way, correct me if I'm wrong.

Before:
image showing previous rendering state, some tanks are white

After:
image showing fixed rendering state, tanks which are previously white are now colored

Liquid dyes are no longer drawn as white.

How Has This Been Tested?

  • Feature has been tested ingame on both neoforge and fabric.
  • Tested with Create: Dragons Plus fluids

Checklist:

  • My code uses the 'var' keyword where applicable.
  • [N/A] I have commented my code, particularly in hard-to-understand areas - N/A, I believe there's no need for extra comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant