feat(logsql): support the json_array_concat pipe (VL v1.51+)#482
Open
szibis wants to merge 1 commit into
Open
Conversation
VictoriaLogs added the json_array_concat pipe upstream, which made the "Check VL upstream AST coverage" job fail (new construct not in the registry). Add the PipeJSONArrayConcat AST node, parser and round-trip String() covering: | json_array_concat [delimiter] [from <src_field>] [as <result_field>] All parts are optional, mirroring the existing PipeSplit. Updates scripts/vl-ast-coverage.json and adds coverage + parser round-trip tests. The coverage check now reports no gaps.
Contributor
PR Quality ReportCompared against base branch Coverage and tests
Compatibility
Performance smokeLower CPU cost (
State
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
internal/logsqlsupport for VictoriaLogs'json_array_concatpipe:PipeJSONArrayConcatAST node + parser + round-tripString(), mirroring the existingPipeSplit(all parts optional).Why
VictoriaLogs added this pipe upstream (v1.51), which made the
Check VL upstream AST coveragejob start failing repo-wide (new construct not inscripts/vl-ast-coverage.json). This closes that gap and lets the proxy parse/round-trip user LogsQL that uses the pipe.Verification
go build ./...✅,go vet✅,go test ./internal/logsql/✅FuzzParseRoundTrip6M execs, no crash ✅scripts/check-vl-ast-coverage.py→ "No gaps found" ✅ (was reportingjson_array_concatas a new construct)First of the VictoriaLogs v1.52 native-feature series.