Skip to content

Remove CORS proxy client code and service implementation #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzurowski merged 2 commits into from
Sep 16, 2026
+4 −42
Merged

Remove CORS proxy client code and service implementation #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0df383d
Stop using CORS proxy for papers
gzurowski Sep 16, 2026
18413c9
Remove proxy service
gzurowski Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/work/WorkDocument.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export const WorkDocument = ({ work, metadata }: WorkDocumentProps) => {
<div className="bg-white rounded-lg shadow-sm border mb-6 relative">
{work.pdfCopyrightAllowsDisplay ? (
<DocumentViewer
url={pdfFormat.internalUrl || pdfFormat.url}
url={pdfFormat.url}
className="min-h-[800px]"
onPdfUnavailable={() => setPdfUnavailable(true)}
/>
Expand Down
21 changes: 0 additions & 21 deletions services/proxy.service.ts
View file
Open in desktop

This file was deleted.

23 changes: 3 additions & 20 deletions types/work.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { Topic, transformTopic } from './topic';
import { createTransformer, BaseTransformed } from './transformer';
import { Hub } from './hub';
import { NoteWithContent, transformNoteWithContent } from './note';
import { ProxyService } from '../services/proxy.service';
import { stripHtml } from '../utils/stringUtils';
import { transformUser, TransformedUser } from './user';
import { transformTip, Tip } from './tip';
import { transformProposalReview, type ProposalReview } from './aiPeerReview';
import type { FundingPool, GrantApplicationVisibility } from './grant';
Expand Down Expand Up @@ -74,10 +72,6 @@ export type DocumentVersion = {
export interface FormatType {
type: string;
url: string;
/**
* This is a proxied URL for internal use (e.g., to avoid CORS issues when rendering PDFs).
*/
internalUrl?: string;
}

export interface Work {
Expand Down Expand Up @@ -320,21 +314,10 @@ export const transformWork = createTransformer<any, Work>((raw) => {
doi: raw.doi,
journal: transformJournal(raw),
formats: raw.file
? [...(raw.formats || []), { type: 'PDF', url: raw.file, internalUrl: raw.file }]
? [...(raw.formats || []), { type: 'PDF', url: raw.file }]
: raw.pdf_url
? [
...(raw.formats || []),
{
type: 'PDF',
url: raw.pdf_url,
internalUrl: ProxyService.generateProxyUrl(raw.pdf_url),
},
]
: (raw.formats || []).map((format: FormatType) => ({
...format,
internalUrl:
format.type === 'PDF' ? ProxyService.generateProxyUrl(format.url) : undefined,
})),
? [...(raw.formats || []), { type: 'PDF', url: raw.pdf_url }]
: raw.formats || [],
license: raw.pdf_license,
pdfCopyrightAllowsDisplay: raw.pdf_copyright_allows_display,
figures: raw.first_preview
Expand Down
Loading